Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update to esbuild 0.14.3 #5861

Merged
merged 10 commits into from
Dec 29, 2021
Merged

chore(deps): update to esbuild 0.14.3 #5861

merged 10 commits into from
Dec 29, 2021

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Nov 27, 2021 •
edited
Loading

Description

Upgrade to esbuild 0.14.3 and Typescript 4.5 (TS was updated in #6297)

The main breaking changes that may affect us (Vue and Svelte components) is:

Add support for TypeScript's preserveValueImports setting
TypeScript 4.5, which was just released, added a new setting called preserveValueImports. This release of esbuild implements support for this new setting. However, this release also changes esbuild's behavior regarding the importsNotUsedAsValues setting, so this release is being considered a breaking change. Now esbuild's behavior should more accurately match the behavior of the TypeScript compiler. This is described in more detail below.
The difference in behavior is around unused imports. By default, unused import names are considered to be types and are completely removed if they are unused. If all import names are removed for a given import statement, then the whole import statement is removed too. The two tsconfig.json settings importsNotUsedAsValues and preserveValueImports let you customize this.

Check the esbuild 0.14 changelog

This PR modifies one of our tests because of this breaking change and adds a new one. It is commented with a TODO at this point because I'm seeing an issue with the option not being listed in the esbuild definitions. If you see why this is happening, please let me know. We'll need to raise an issue in esbuild if not.

As per a discussion with @sodatea and @Shinigami92, we would like to target vite 2.8

Edit: esbuild is fixed to 0.14.3 because there are breaking changes in 0.14.4, see https://github.com/evanw/esbuild/blob/master/CHANGELOG.md#0144

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Nov 27, 2021
@patak-dev patak-dev added this to the 2.8 milestone Nov 27, 2021
@Shinigami92 Shinigami92 self-requested a review November 27, 2021 11:23
@patak-dev patak-dev mentioned this pull request Nov 27, 2021
Closed
9 tasks
@frederikhors
Copy link

Can you please split this PR in two?

One for esbuild 0.14 and one for ts 4.5?

@patak-dev
Copy link
Member Author

@frederikhors esbuild 0.14 changes the logic of some options that requires Typescript 4.5 (preserveValueImports). We should update them together. The idea is to release 2.7 soon, and then update both deps in 2.8. Is there a reason I'm not seeing for doing these separately?
I don't know if we should update to TS 4.5 now because we want to end the beta period and release 2.7 as soon as possible

@frederikhors
Copy link

I need 0.14 for comments fixes. That's it. I thought it can be easier to split this PR.

antfu
antfu reviewed Nov 29, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@patak-dev @antfu
chore: correct version range
595db8d 
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
@patak-dev
Copy link
Member Author

I need 0.14 for comments fixes. That's it. I thought it can be easier to split this PR.

We can't update without TS 4.5 so it would be the same. We are going to try to release 2.8 soon enough, we also want these two deps updated

@patak-dev patak-dev mentioned this pull request Nov 29, 2021
Merged
9 tasks
Shinigami92
Shinigami92 previously approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved it from my side for now, others should have a look as well because this could really break thinks (again)

@Niputi Niputi added the dependencies Pull requests that update a dependency file label Dec 17, 2021
@Niputi Niputi mentioned this pull request Dec 17, 2021
Closed
7 tasks
@patak-dev patak-dev mentioned this pull request Dec 29, 2021
Merged
4 tasks
@patak-dev patak-dev changed the title chore: update to esbuild 0.14 and Typescript 4.5 chore(deps): update to esbuild 0.14.3 Dec 29, 2021
Shinigami92
Shinigami92 approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, I think it's okay to merge it.
Just had one question above.

@patak-dev patak-dev merged commit 44bb4da into main Dec 29, 2021
@patak-dev patak-dev deleted the esbuild-0-14 branch December 29, 2021 11:51
@frederikhors
Copy link

Thanks for the merge. When this will ship? 2.8?

@Niputi
Copy link
Contributor

Niputi commented Dec 29, 2021

yes. 2.8 in January

poyoho added a commit to poyoho/vite that referenced this pull request Dec 30, 2021
@poyoho
Squashed commit of the following:
1d5d432 
commit d856c4b
Author: Anthony Fu <anthonyfu117@hotmail.com>
Date:   Thu Dec 30 00:25:59 2021 +0800

    fix(ssr): move `vite:ssr-require-hook` after user plugins (vitejs#6306)

commit b45f4ad
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Dec 29 14:49:15 2021 +0100

    chore(deps): update all non-major dependencies (vitejs#6185)

commit 4d75b2e
Author: Niputi <7137178+Niputi@users.noreply.github.com>
Date:   Wed Dec 29 14:48:13 2021 +0100

    feat: catch postcss error messages (vitejs#6293)

commit f68ed8b
Author: Bogdan Chadkin <trysound@yandex.ru>
Date:   Wed Dec 29 16:40:13 2021 +0300

    fix: replace execa with cross-spawn (vitejs#6299)

commit 44bb4da
Author: patak <matias.capeletto@gmail.com>
Date:   Wed Dec 29 12:51:46 2021 +0100

    chore(deps): update to esbuild fixed at 0.14.3 (vitejs#5861)

commit 9ad7c55
Author: patak <matias.capeletto@gmail.com>
Date:   Wed Dec 29 11:32:49 2021 +0100

    deps: update to typescript 4.5.4 (vitejs#6297)

commit 1da104e
Author: Aron Griffis <aron@scampersand.com>
Date:   Wed Dec 29 02:50:19 2021 -0500

    fix: don't force terser on non-legacy (fix vitejs#6266) (vitejs#6272)

commit 5279de6
Author: ygj6 <7699524+ygj6@users.noreply.github.com>
Date:   Wed Dec 29 05:30:47 2021 +0800

    feat: import.meta.glob support ?raw (vitejs#5545)

commit 6d4ee18
Author: Bjorn Lu <bjornlu.dev@gmail.com>
Date:   Wed Dec 29 04:27:49 2021 +0800

    feat(define): prevent assignment (vitejs#5515)

commit ac3f434
Author: Bogdan Chadkin <trysound@yandex.ru>
Date:   Tue Dec 28 23:26:46 2021 +0300

    fix: upgrade postcss-modules (vitejs#6248)

commit 5a111ce
Author: Bogdan Chadkin <trysound@yandex.ru>
Date:   Tue Dec 28 23:23:42 2021 +0300

    fix: replace chalk with picocolors (vitejs#6277)

commit 7e3e84e
Author: patak-dev <matias.capeletto@gmail.com>
Date:   Tue Dec 28 15:07:10 2021 +0100

    release: v2.7.9

commit 83ad7bf
Author: Anthony Fu <anthonyfu117@hotmail.com>
Date:   Tue Dec 28 21:52:41 2021 +0800

     fix: revert vitejs#6251 (vitejs#6290)

    This reverts commit 49da986.

commit 1cbf0e1
Author: Cristian Pallarés <cristian@pallares.io>
Date:   Tue Dec 28 11:30:42 2021 +0100

    test: fix test typo (vitejs#6285)

commit d13ced5
Author: patak-dev <matias.capeletto@gmail.com>
Date:   Tue Dec 28 09:40:48 2021 +0100

    release: v2.7.8

commit dcb1df4
Author: itibbers <jxn2014@gmail.com>
Date:   Tue Dec 28 16:30:32 2021 +0800

    docs: add frontmatters to fix __VP_STATIC_START__ (vitejs#6283)

commit 60ce7f9
Author: Anthony Fu <anthonyfu117@hotmail.com>
Date:   Tue Dec 28 16:20:12 2021 +0800

    fix(ssr): capture scope declaration correctly (vitejs#6281)

commit eb08ec5
Author: Niputi <7137178+Niputi@users.noreply.github.com>
Date:   Tue Dec 28 06:10:37 2021 +0100

    chore: remove acorn plugins (vitejs#6275)

commit 64b1595
Author: zhangenming <282126346@qq.com>
Date:   Tue Dec 28 11:52:51 2021 +0800

    chore(create-vite): add more gitignore (vitejs#6247)

commit 49da986
Author: sanyuan <39261479+sanyuan0704@users.noreply.github.com>
Date:   Tue Dec 28 05:30:54 2021 +0800

    fix: seperate source and dep for dymamic import after build (vitejs#6251)

commit 394539c
Author: Bogdan Chadkin <trysound@yandex.ru>
Date:   Tue Dec 28 00:29:23 2021 +0300

    fix: upgrade to launch-editor with picocolors (vitejs#6209)

commit 40e3f73
Author: Shinigami <chrissi92@hotmail.de>
Date:   Mon Dec 27 11:42:24 2021 +0100

    chore: fix link (vitejs#6269)

commit e7306b5
Author: Shinigami <chrissi92@hotmail.de>
Date:   Mon Dec 27 11:22:44 2021 +0100

    chore: update bug report issue template (vitejs#6263)

commit 1f945f6
Author: Aaron Bassett <arbassett4@outlook.com>
Date:   Sun Dec 26 15:28:47 2021 -0500

    fix(html): show error overlay when parsing invalid file (vitejs#6184)

commit 1d722c5
Author: patak-dev <matias.capeletto@gmail.com>
Date:   Sun Dec 26 06:35:04 2021 +0100

    release: v2.7.7

commit 2e3fe59
Author: Anthony Fu <anthonyfu117@hotmail.com>
Date:   Sun Dec 26 13:13:24 2021 +0800

    fix(ssr): transform class props (vitejs#6261)

commit 1a6e2da
Author: ygj6 <7699524+ygj6@users.noreply.github.com>
Date:   Sat Dec 25 18:24:44 2021 +0800

    docs: typescript tips for using Type-Only Imports and Export (vitejs#6260)

commit 6a47083
Author: Haoqun Jiang <haoqunjiang@gmail.com>
Date:   Fri Dec 24 14:02:43 2021 +0800

    fix: update the vue version in the error message (vitejs#6252)

commit 485e298
Author: Anthony Fu <anthonyfu117@hotmail.com>
Date:   Thu Dec 23 21:45:13 2021 +0800

    fix(ssr): nested destucture (vitejs#6249)
@patak-dev patak-dev mentioned this pull request Jan 26, 2022
Merged
4 tasks
@AlexandreBonaventure AlexandreBonaventure mentioned this pull request May 26, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikhors frederikhors frederikhors left review comments

@antfu antfu antfu left review comments

@benmccann benmccann benmccann left review comments

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file on hold p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
6 participants
@patak-dev @frederikhors @Niputi @benmccann @Shinigami92 @antfu