fix(build): NODE_ENV override by .env

[RainKolwa]

Description

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[bluwy]

Fixes #6302

[bluwy]

This and #6304 are solving the same issue. But I think #6304 is more correct as currently .env has higher priority over .env.mode. This PR switches the priority for NODE_ENV only, which would be inconsistent.

I do however think that Vite is sorting the priority in reverse than expected though. But fixing it would be a breaking change.

[patak-dev]

@bluwy would you like to PR reverting the priority? We can discuss it next week (Friday), and maybe include it in 2.8? It may be too big of a change for a minor and we may need to leave it for 3.0 in May/June

[poyoho]

If we want to change I still think this should be changed 😀. Should be caused by the order here ?

[Shinigami92]

If we want to change I still think this should be changed grinning. Should be caused by the order here ?

Why? If I understand line

vite/packages/vite/src/node/config.ts

Line 1016 in dd8869b

env[key] === undefined

correctly, then it first use the most specific file and defines the vars.
If another file gets to this same var, it will not override it anymore 🤔 and IMO this is exactly what we want, do we?

[userquin]

check https://cli.vuejs.org/guide/mode-and-env.html#environment-variables, see green alert with title Env Loading Priorities, vite works as expected, we can add this green hint also on vite docs (added this comment also on #6304 )

https://discord.com/channels/804011606160703521/804011606160703524/926173658219708416

[poyoho]

you are right! 👍

[bluwy]

Uhhh I should've tested the .env priority locally. Looks like the priority is indeed working properly and only NODE_ENV wasn't handled right. We should keep this PR then. My bad!

[bluwy]

Would be great to get this merged to fix the issue. The changes looks good to me.