Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(lib-mode): add a caveat to the build.minify docs for 'es' format #6314

Merged
merged 2 commits into from
Dec 30, 2021

Conversation

seanwatters
Copy link
Contributor

@seanwatters seanwatters commented Dec 30, 2021

Description

Update docs to reflect that the build.minify option does not work in "lib mode" for the 'es' format.

Additional context

see this commit for reference: 06d86e4

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

see this commit for reference: vitejs@06d86e4
@Niputi Niputi added the documentation Improvements or additions to documentation label Dec 30, 2021
@Niputi
Copy link
Contributor

Niputi commented Dec 30, 2021

if we merge this, we might as well close #5167

@seanwatters
Copy link
Contributor Author

if we merge this, we might as well close #5167

Ah, I was unaware that there was an open MR for resolving this. I don't have a preference as to whether or not Vite supports this or it requires explicitly including terser/esbuild plugins; I do however think it would be useful to at least include this note in the docs until it has been decided one way or the other.

@Niputi
Copy link
Contributor

Niputi commented Dec 30, 2021

please run pnpm run format to get lint successful

@Niputi Niputi linked an issue Dec 30, 2021 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to minify es format in library mode
4 participants