Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-enable minifying es lib #6670

Closed
wants to merge 3 commits into from
Closed

Conversation

Kurtil
Copy link

@Kurtil Kurtil commented Jan 28, 2022

Description

@yyx990803 said "We should probably default to not minifying in lib mode in Vite" here.

Instead of this requested behaviour, this commit 06d86e4 prevents es libs to be minified even if the minify option is set to true, esbuild or terser.

This PR change the default value of the minify option to false if a lib option is present, re-enabling minifying es lib if minify is requested.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@Kurtil Kurtil changed the title Re-enabled minifying es lib fix: Re-enabled minifying es lib Jan 28, 2022
@Kurtil Kurtil changed the title fix: Re-enabled minifying es lib fix: Re-enable minifying es lib Jan 28, 2022
@Kurtil
Copy link
Author

Kurtil commented Jan 28, 2022

This solves #5167 @DerYeger ;)

@Niputi
Copy link
Contributor

Niputi commented Jan 28, 2022

needs to follow #6555

@Kurtil Kurtil mentioned this pull request Jan 28, 2022
4 tasks
@bluwy
Copy link
Member

bluwy commented Apr 1, 2023

Closing in favour of #6585. Minifying es lib today also works partially now, es.min would be going another mile to remove possible treeshaking hints.

@bluwy bluwy closed this Apr 1, 2023
@Kurtil Kurtil deleted the minifyEsLib branch April 3, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants