Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace SourceMapConsumer with trace-mapping #6746

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Feb 3, 2022

ampproject/remapping split own helper into separate package. Now we can
reuse it instead of SourceMapConsumer.

du -ck dist/node

before: 4140
after: 4068

PS: trace-mapping has smaller license 😄

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

ampproject/remapping split own helper into separate package. Now we can
reuse it instead of SourceMapConsumer.

```
du -ck dist/node
```
before: 4140
after: 4068
@Niputi Niputi added dependencies Pull requests that update a dependency file p1-chore Doesn't change code behavior (priority) labels Feb 3, 2022
@Niputi Niputi added this to the 2.9 milestone Feb 9, 2022
@patak-dev
Copy link
Member

@TrySound would you check the conflicts? We can merge this one as part of the 2.9 beta.

@patak-dev patak-dev merged commit ed4d191 into vitejs:main Mar 8, 2022
@TrySound
Copy link
Contributor Author

TrySound commented Mar 8, 2022

Sorry, didn't have time lately

@TrySound TrySound deleted the trace-mapping branch March 8, 2022 12:48
@patak-dev
Copy link
Member

No problem, thanks again for all your work @TrySound, take care ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file p1-chore Doesn't change code behavior (priority)
Projects
No open projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants