-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add assets inline exclude #6892
Conversation
Closes #2173 |
Thanks for the PR! I think that it would be good to refactor the options to be
So we can use the usual include/exclude But let's wait to see what other maintainers think. I'll add it for discussion in our next team meeting (we just had one, so a bit of patience since we are going to get to this one in two weeks). |
Thanks, looking forward to the next changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some picky advice 😊
Any update on this? would love this feature 🙏 |
emmm... I also think the PR need to #6892 (comment). |
I also have this problem, but I don't think this is a correct solution. May I offer an alternative solution Make it a callback with the file, filesize, and just for kicks, current total size of everything included so far. |
Cleaning up stale PRs. The discussion notes for this favoured the API in #8717 instead with a function form. Closing this for now. |
Description
Closes #2173
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).