-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(create-vite-app): upgrade react to 18 #7597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait until CRA updates their templates, so we can reference that as the canonical style guide.
"@vitejs/plugin-react": "^1.3.0", | ||
"vite": "^2.9.1", | ||
"@types/react": "^17.0.43", | ||
"@types/react-dom": "^17.0.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are out of order (alphabetically)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the ordering
I'm getting a type error when building:
|
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Description
Upgrades react to v18.0.0 in
template-react
&template-react-ts
in create-vite-app package.fixes #7519
Additional context
React recently released v18 with concurrent features, this PR aims to provide vite template with concurrent features enabled.
In addition to using react concurrent features, this PR adds
@types/react
and@types/react-dom
in the template so that the users can get better Intellisense and automatic imports when usingtemplate-react
.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).