Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hmr): correct hmr for sfc has setup script when it template change #763

Merged
merged 4 commits into from
Aug 31, 2020
Merged

fix(hmr): correct hmr for sfc has setup script when it template change #763

merged 4 commits into from
Aug 31, 2020

Conversation

underfin
Copy link
Member

@underfin underfin commented Aug 28, 2020 •
edited
Loading

fix #748

antfu
antfu reviewed Aug 29, 2020
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the newCache only be used once and it's a bit far from where it being used. Maybe it's better to do it inline?

src/node/server/serverPluginVue.ts Outdated Show resolved Hide resolved
src/node/server/serverPluginVue.ts Outdated Show resolved Hide resolved
@underfin underfin requested a review from antfu August 30, 2020 10:09
@underfin underfin merged commit 9bea946 into vitejs:master Aug 31, 2020
@underfin underfin deleted the setup-script-should-fullly-hmr-when-template-change branch August 31, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't find component on template refresh when importing component in script setup
2 participants
@underfin @antfu