Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(optimize-missing-deps): rewrite deps in CJS #8025

Merged
merged 1 commit into from
May 5, 2022

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented May 5, 2022

Description

Fix test optimize-missing-deps, rewrite deps with CJS. This will pass #6698 failing test and eliminate the following warning:
image

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

Would you explain why the current esm wasnt working? Could it break user code or is it just an artifact of our test setup?

@ygj6
Copy link
Member Author

ygj6 commented May 5, 2022

Would you explain why the current esm wasnt working?

Because we don't have field type: "module" in missing-dep's package.json, if we externalize it, Vite treats it as CJS that raised the error. While we could add this field to package.json, when I try it, I found that jest does not support running ESM in Node environment. So I think the solution is make the deps as CJS.

it just an artifact of our test setup?

yes

@patak-dev patak-dev merged commit e32a3a8 into vitejs:main May 5, 2022
benmccann added a commit to benmccann/vite that referenced this pull request May 7, 2022
benmccann added a commit to benmccann/vite that referenced this pull request May 10, 2022
benmccann added a commit to benmccann/vite that referenced this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants