Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: bump targets #8045

Merged
merged 7 commits into from
May 18, 2022
Merged

build!: bump targets #8045

merged 7 commits into from
May 18, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented May 6, 2022

Description

Bumping targets

Additional context

According to this table https://kangax.github.io/compat-table/es2016plus/ it is mostly safe to go with ES2020
The lowest node version would be v14.6.0. This is also the requirement in package.json and in vitest and other "modern" packages.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 self-assigned this May 6, 2022
docs/config/index.md Outdated Show resolved Hide resolved
docs/config/index.md Show resolved Hide resolved
docs/guide/assets.md Outdated Show resolved Hide resolved
docs/guide/build.md Outdated Show resolved Hide resolved
packages/vite/src/node/build.ts Outdated Show resolved Hide resolved
packages/vite/src/node/build.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 marked this pull request as ready for review May 18, 2022 15:16
bluwy
bluwy previously approved these changes May 18, 2022
@sapphi-red
Copy link
Member

I think you forgot to change this one.

"target": "ES2018",

@Shinigami92
Copy link
Member Author

I think you forgot to change this one.

"target": "ES2018",

I did not forgot that, I left that over due to this is the legacy plugin

Co-authored-by: 翠 / green <green@sapphi.red>
@sapphi-red
Copy link
Member

sapphi-red commented May 18, 2022

I think you forgot to change this one.

"target": "ES2018",

I did not forgot that, I left that over due to this is the legacy plugin

IIUC plugin-legacy enables bundled code to be able to run in legacy browsers, but the plugin itself does not run in legacy browsers (it requires node 14.16+).
So I think it could be changed.

@Shinigami92
Copy link
Member Author

IIUC plugin-legacy enables bundled code to be able to run in legacy browsers, but the plugin itself does not run in legacy browsers (it requires node 14.16+). So I think it could be changed.

@patak-dev Could you approve this statement?

@patak-dev
Copy link
Member

@Shinigami92 yes, internal Vite plugins will also require Node 14.16+, same as core.

@patak-dev patak-dev merged commit 66efd69 into main May 18, 2022
@patak-dev patak-dev deleted the bump-targets branch May 18, 2022 20:15
@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants