feat: handle named imports of builtin modules #8338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #3736
Fix #8203
Ref #3715 (comment) (fix no1)
Handle
import { join } from 'path'
in deps and source code. (named imports)In deps, wrap proxy with
Object.create
to workaround esbuild ES interop code.In source code, transform the import to
import pkg from 'path'; const { join } = pkg;
(es interop)Additional context
const { join } = require('path')
, it would error immediately asjoin
triggers the Proxy get trap on destructure. (ES import don't have this issue due to compiled esbuild code)Thanks @swandir for initial inspiration for the Proxy trick. Though it has evolved a lot since then.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).