Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid errors when loading the overlay code in workers #9064

Merged
merged 2 commits into from
Jul 15, 2022
Merged

fix: avoid errors when loading the overlay code in workers #9064

merged 2 commits into from
Jul 15, 2022

Commits on Jul 13, 2022

  1. Avoid errors when loading the overlay code in workers. 

    `HTMLElement` and `customElements` are not defined in e.g. web workers. However, Vite sometimes tries to inject the overlay into such workers. Ideally, it would not do so (and would e.g. find another way to notify the developer about issues). But this PR offers a change that allows such workers to run, by avoiding crashes in `overlay.ts` when it does.
    @lgarron
    lgarron committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    9bbeec2 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. chore: format

    @patak-dev
    patak-dev committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    4c4260e View commit details
    Browse the repository at this point in the history