Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): rename objectPattern dynamic key (fixes #9585) #9609

Merged

Conversation

sapphi-red
Copy link
Member

Description

import { n } from 'foo'
const { [n]: bar } = {} // this "n" was not renamed

This PR fixes #9585.

Additional context

Changed isNodeInPatternWeakMap to a WeakSet as the value was not used.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) feat: ssr labels Aug 10, 2022
@patak-dev patak-dev merged commit ee7f78f into vitejs:main Aug 10, 2022
@sapphi-red sapphi-red deleted the fix/ssr-rename-object-pattern-dynamic-key branch August 10, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named export is not defined when used destructuring an object
2 participants