-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typo #9855
docs: fix typo #9855
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -25,7 +25,7 @@ export interface WebSocketServer { | |||||
*/ | ||||||
clients: Set<WebSocketClient> | ||||||
/** | ||||||
* Boardcast events to all clients | ||||||
* Broadcast events to all clients | ||||||
*/ | ||||||
send(payload: HMRPayload): void | ||||||
/** | ||||||
|
@@ -108,7 +108,7 @@ export function createWebSocketServer( | |||||
const port = hmrPort || 24678 | ||||||
const host = (hmr && hmr.host) || undefined | ||||||
if (httpsOptions) { | ||||||
// if we're serving the middlewares over https, the ws library doesn't support automatically creating an https server, so we need to do it ourselves | ||||||
// if we're serving the middlewares over https, the ws library doesn't support automatically creating a https server, so we need to do it ourselves | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
The original text is correct. Use |
||||||
// create an inline https server and mount the websocket server to it | ||||||
httpsServer = createHttpsServer(httpsOptions, (req, res) => { | ||||||
const statusCode = 426 | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -18,7 +18,7 @@ test('deep import with exports field', async () => { | |||||
}) | ||||||
|
||||||
test('deep import with query with exports field', async () => { | ||||||
// since it is imported with `?url` it should return a url | ||||||
// since it is imported with `?url` it should return an url | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Similar to issue above with the unsounded |
||||||
expect(await page.textContent('.exports-deep-query')).toMatch( | ||||||
isBuild ? /base64/ : '/exports-path/deep.json' | ||||||
) | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,7 +1,7 @@ | ||||||
import { defineConfig } from 'vite' | ||||||
export default defineConfig({ | ||||||
build: { | ||||||
// make can no emit light.wasm | ||||||
// make can not emit light.wasm | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
// and emit add.wasm | ||||||
assetsInlineLimit: 80 | ||||||
} | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.