Skip to content

Commit

Permalink
Revert "Tag analyzer diagnostics as non configurable (dotnet#2252)" (d…
Browse files Browse the repository at this point in the history
…otnet#2257)

This reverts commit 3e5edda.
  • Loading branch information
mateoatr authored Sep 3, 2021
1 parent 39505a8 commit e160ad7
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions src/ILLink.RoslynAnalyzer/DiagnosticDescriptors.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ public static DiagnosticDescriptor GetDiagnosticDescriptor (DiagnosticId diagnos
diagnosticString.GetMessageFormat (),
GetDiagnosticCategory (diagnosticId),
DiagnosticSeverity.Warning,
true,
customTags: WellKnownDiagnosticTags.NotConfigurable);
true);
}

public static DiagnosticDescriptor GetDiagnosticDescriptor (DiagnosticId diagnosticId, DiagnosticString diagnosticString)
Expand All @@ -28,8 +27,7 @@ public static DiagnosticDescriptor GetDiagnosticDescriptor (DiagnosticId diagnos
diagnosticString.GetMessage (),
GetDiagnosticCategory (diagnosticId),
DiagnosticSeverity.Warning,
true,
customTags: WellKnownDiagnosticTags.NotConfigurable);
true);

public static DiagnosticDescriptor GetDiagnosticDescriptor (DiagnosticId diagnosticId,
LocalizableResourceString? lrsTitle = null,
Expand All @@ -47,8 +45,7 @@ public static DiagnosticDescriptor GetDiagnosticDescriptor (DiagnosticId diagnos
diagnosticCategory ?? GetDiagnosticCategory (diagnosticId),
diagnosticSeverity,
isEnabledByDefault,
helpLinkUri,
customTags: WellKnownDiagnosticTags.NotConfigurable);
helpLinkUri);
}

return new DiagnosticDescriptor (diagnosticId.AsString (),
Expand All @@ -57,8 +54,7 @@ public static DiagnosticDescriptor GetDiagnosticDescriptor (DiagnosticId diagnos
diagnosticCategory ?? GetDiagnosticCategory (diagnosticId),
diagnosticSeverity,
isEnabledByDefault,
helpLinkUri,
customTags: WellKnownDiagnosticTags.NotConfigurable);
helpLinkUri);
}

static string GetDiagnosticCategory (DiagnosticId diagnosticId)
Expand Down

0 comments on commit e160ad7

Please sign in to comment.