-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zarrita rather than zarr.js #1680
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +874 kB (+8%) 🔍 Total Size: 12.5 MB
ℹ️ View Unchanged
|
Coverage Report
File Coverage
|
12 tasks
Cool! Want to chat this week about the zarrita TODOs? I can take a stab at improving these |
@manzt yes! Will follow up on slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Background
<i8
integers. ZarrJS does not support these Support BigInt64Array gzuidhof/zarr.js#143<U7
[]
)Change List
TODO
ZarritaPixelSource
to viv: CurrentZarrPixelSource
does not tree-shake-out ZarrJS because it imports itsslice
function Allow for passing slice type hms-dbmi/viv#698.attrs
open()
afterroot()
in order to accessawait
zarr.rootnode:
prefix webpack/webpack#14166)