The warning code field should be called "Code", not "Type".

Signed-off-by: Jacques Grove <aquarapid@gmail.com>
vitessio · Jul 10, 2020 · 0e0ac05 · 0e0ac05
1 parent 9c86ca2
commit 0e0ac05
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/go/vt/vtgate/executor.go b/go/vt/vtgate/executor.go
@@ -959,7 +959,7 @@ func (e *Executor) handleShow(ctx context.Context, safeSession *SafeSession, sql
  case sqlparser.KeywordString(sqlparser.WARNINGS):
  fields := []*querypb.Field{
  {Name: "Level", Type: sqltypes.VarChar},
- {Name: "Type", Type: sqltypes.Uint16},
+ {Name: "Code", Type: sqltypes.Uint16},
  {Name: "Message", Type: sqltypes.VarChar},
  }
  rows := make([][]sqltypes.Value, 0)

diff --git a/go/vt/vtgate/executor_test.go b/go/vt/vtgate/executor_test.go
@@ -851,7 +851,7 @@ func TestExecutorShow(t *testing.T) {
  wantqr = &sqltypes.Result{
  Fields: []*querypb.Field{
  {Name: "Level", Type: sqltypes.VarChar},
- {Name: "Type", Type: sqltypes.Uint16},
+ {Name: "Code", Type: sqltypes.Uint16},
  {Name: "Message", Type: sqltypes.VarChar},
  },
  Rows: [][]sqltypes.Value{},
@@ -868,7 +868,7 @@ func TestExecutorShow(t *testing.T) {
  wantqr = &sqltypes.Result{
  Fields: []*querypb.Field{
  {Name: "Level", Type: sqltypes.VarChar},
- {Name: "Type", Type: sqltypes.Uint16},
+ {Name: "Code", Type: sqltypes.Uint16},
  {Name: "Message", Type: sqltypes.VarChar},
  },
  Rows: [][]sqltypes.Value{},
@@ -887,7 +887,7 @@ func TestExecutorShow(t *testing.T) {
  wantqr = &sqltypes.Result{
  Fields: []*querypb.Field{
  {Name: "Level", Type: sqltypes.VarChar},
- {Name: "Type", Type: sqltypes.Uint16},
+ {Name: "Code", Type: sqltypes.Uint16},
  {Name: "Message", Type: sqltypes.VarChar},
  },