[release-17.0] Ensure to call servenv.Init when needed (#13638) (#1…

…3643)

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

go/cmd/topo2topo/topo2topo.go

@@ -77,6 +77,7 @@ func main() {
  logutil.RegisterFlags(fs)
 
  servenv.ParseFlags("topo2topo")
+ servenv.Init()
 
  fromTS, err := topo.OpenServer(fromImplementation, fromServerAddress, fromRoot)
  if err != nil {

go/cmd/vtaclcheck/vtaclcheck.go

@@ -47,6 +47,7 @@ func main() {
  defer logutil.Flush()
 
  servenv.ParseFlags("vtaclcheck")
+ servenv.Init()
 
  err := run()
  if err != nil {

go/cmd/vtbench/vtbench.go

@@ -121,6 +121,7 @@ func main() {
  })
 
  servenv.ParseFlags("vtbench")
+ servenv.Init()
 
  defer exit.Recover()
 

go/cmd/vtexplain/vtexplain.go

@@ -104,6 +104,7 @@ func main() {
  defer logutil.Flush()
 
  servenv.ParseFlags("vtexplain")
+ servenv.Init()
  err := parseAndRun()
  if err != nil {
  fmt.Printf("ERROR: %s\n", err)

go/cmd/vtorc/main.go

@@ -104,6 +104,7 @@ func main() {
  fs.StringVar(&configFile, "config", "", "config file name")
  })
  servenv.ParseFlags("vtorc")
+ servenv.Init()
  config.UpdateConfigValuesFromFlags()
 
  log.Info("starting vtorc")

go/cmd/vttestserver/main.go

@@ -268,6 +268,7 @@ func parseFlags() (env vttest.Environment, err error) {
 
 func main() {
  cluster, err := runCluster()
+ servenv.Init()
  if err != nil {
  log.Fatal(err)
  }

go/cmd/zkctld/zkctld.go

@@ -57,6 +57,7 @@ func main() {
  defer logutil.Flush()
 
  servenv.ParseFlags("zkctld")
+ servenv.Init()
  zkConfig := zkctl.MakeZkConfigFromString(zkCfg, uint32(myID))
  zkd := zkctl.NewZkd(zkConfig)