update failing test assertion

Signed-off-by: Andres Taylor <andres@planetscale.com>
vitessio · Oct 30, 2020 · 5b1234b · 5b1234b
1 parent 6f17514
commit 5b1234b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/go/test/endtoend/vtgate/unsharded/main_test.go b/go/test/endtoend/vtgate/unsharded/main_test.go
@@ -174,7 +174,7 @@ func TestInsertAllDefaults(t *testing.T) {
 	defer conn.Close()
 
 	exec(t, conn, `insert into allDefaults () values ()`)
-	assertMatches(t, conn, `select * from allDefaults`, `"[[INT64(1) NULL]]"`)
+	assertMatches(t, conn, `select * from allDefaults`, "[[INT64(1) NULL]]")
 }
 
 func exec(t *testing.T, conn *mysql.Conn, query string) *sqltypes.Result {

diff --git a/go/vt/vtgate/planbuilder/testdata/dml_cases.txt b/go/vt/vtgate/planbuilder/testdata/dml_cases.txt
@@ -943,7 +943,22 @@
 
 # insert sharded, no values
 "insert into user values()"
-"no column list"
+{
+  "QueryType": "INSERT",
+  "Original": "insert into user values()",
+  "Instructions": {
+    "OperatorType": "Insert",
+    "Variant": "Sharded",
+    "Keyspace": {
+      "Name": "user",
+      "Sharded": true
+    },
+    "TargetTabletType": "MASTER",
+    "MultiShardAutocommit": false,
+    "Query": "insert into user(id, Name, Costly) values (:_Id_0, :_Name_0, :_Costly_0)",
+    "TableName": "user"
+  }
+}
 
 # insert with one vindex
 "insert into user(id) values (1)"