Skip to content

Commit

Permalink
Add timeout to golangci-lint and bump its version (#12852) (#12853)
Browse files Browse the repository at this point in the history
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
  • Loading branch information
frouioui authored Apr 11, 2023
1 parent db8bf83 commit c76f44f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/static_checks_etc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ jobs:
- name: Install golangci-lint
if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.go_files == 'true'
run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46.2
run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2

- name: Clean Env
if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.go_files == 'true'
Expand All @@ -170,7 +170,7 @@ jobs:

- name: Run golangci-lint
if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.go_files == 'true'
run: $(go env GOPATH)/bin/golangci-lint run go/... || exit 1
run: $(go env GOPATH)/bin/golangci-lint run go/... --timeout 10m || exit 1

- name: Run go mod tidy
if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.go_files == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -158,4 +158,4 @@ issues:

# https://github.com/golangci/golangci/wiki/Configuration
service:
golangci-lint-version: 1.50.1 # use the fixed version to not introduce new linters unexpectedly
golangci-lint-version: 1.52.2 # use the fixed version to not introduce new linters unexpectedly

0 comments on commit c76f44f

Please sign in to comment.