Skip to content

Commit

Permalink
VDiff CLI: Fix VDiff show bug (#16177)
Browse files Browse the repository at this point in the history
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
  • Loading branch information
vitess-bot[bot] committed Jun 15, 2024
1 parent 6ff19c9 commit edb6e77
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion go/cmd/vtctldclient/command/vreplication/vdiff/vdiff.go
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,6 @@ func getStructFieldNames(s any) []string {
}

func buildListings(listings []*listing) string {
var values []string
var lines [][]string
var result string

Expand All @@ -474,6 +473,7 @@ func buildListings(listings []*listing) string {
// The header is the first row.
lines = append(lines, fields)
for _, listing := range listings {
var values []string

Check warning on line 476 in go/cmd/vtctldclient/command/vreplication/vdiff/vdiff.go

View check run for this annotation

Codecov / codecov/patch

go/cmd/vtctldclient/command/vreplication/vdiff/vdiff.go#L476

Added line #L476 was not covered by tests
v := reflect.ValueOf(*listing)
for _, field := range fields {
values = append(values, v.FieldByName(field).String())
Expand Down

0 comments on commit edb6e77

Please sign in to comment.