-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch flag definitions to be on pflag instead of flag in package go/vt/servenv
#11144
Labels
Component: CLI
Component: General
Changes throughout the code base
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Type: Internal Cleanup
Comments
3 tasks
ajm188
pushed a commit
to planetscale/vitess
that referenced
this issue
Aug 31, 2022
…flag` Relates to vitessio#11144. Signed-off-by: Andrew Mason <andrew@planetscale.com>
This was referenced Sep 1, 2022
ajm188
pushed a commit
to planetscale/vitess
that referenced
this issue
Sep 7, 2022
Relates to vitessio#11144. Also converts the flag from our custom `StringListValue` to pflag-native `StringSlice`. Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
pushed a commit
to planetscale/vitess
that referenced
this issue
Sep 7, 2022
Relates to vitessio#11144. Signed-off-by: Andrew Mason <andrew@planetscale.com>
3 tasks
ajm188
pushed a commit
that referenced
this issue
Sep 7, 2022
…11179) * unexport CheckServiceMap Signed-off-by: Andrew Mason <andrew@planetscale.com> * [cli] [servenv] Migrate `service_map` to pflag Relates to #11144. Also converts the flag from our custom `StringListValue` to pflag-native `StringSlice`. Signed-off-by: Andrew Mason <andrew@planetscale.com> * [cli] [servenv] Migrate `pprof` flag to `pflag` Relates to #11144. Signed-off-by: Andrew Mason <andrew@planetscale.com> * fix tests Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
pushed a commit
to planetscale/vitess
that referenced
this issue
Sep 7, 2022
Relates to vitessio#11144. Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
pushed a commit
to planetscale/vitess
that referenced
this issue
Sep 7, 2022
Relates to vitessio#11144. Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
pushed a commit
to planetscale/vitess
that referenced
this issue
Sep 7, 2022
Relates to vitessio#11144. Signed-off-by: Andrew Mason <andrew@planetscale.com>
3 tasks
ajm188
pushed a commit
that referenced
this issue
Sep 8, 2022
* [cli] [servenv] Migrate `--socket_file` flag to pflag and un-export Relates to #11144. Signed-off-by: Andrew Mason <andrew@planetscale.com> * [cli] [servenv] Migrate `--pid_file` flag to pflag Relates to #11144. Signed-off-by: Andrew Mason <andrew@planetscale.com> * [cli] [servenv] Correct old flag.Usage call Relates to #11144. Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
pushed a commit
to planetscale/vitess
that referenced
this issue
Sep 8, 2022
Relates to vitessio#11144. Signed-off-by: Andrew Mason <andrew@planetscale.com>
Merged
3 tasks
ajm188
pushed a commit
that referenced
this issue
Sep 8, 2022
…tctldclient` and `vtadmin` (#11189) * unexport servenv.Version Signed-off-by: Andrew Mason <andrew@planetscale.com> * [cli] [servenv] Migrate `--version` flag to pflag Relates to #11144. Signed-off-by: Andrew Mason <andrew@planetscale.com> * [cli] [vtadmin|vtctldclient] Add `--version` flags to cobra commands Closes #10909. Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
pushed a commit
to planetscale/vitess
that referenced
this issue
Sep 8, 2022
Closes vitessio#11144. Signed-off-by: Andrew Mason <andrew@planetscale.com>
3 tasks
ajm188
pushed a commit
that referenced
this issue
Sep 9, 2022
* [sqlparser] Use interoperable flag.Parsed function Signed-off-by: Andrew Mason <andrew@planetscale.com> * [cli] [servenv] Migrate `--mysql_server_version` flag to pflag Closes #11144. Signed-off-by: Andrew Mason <andrew@planetscale.com> * no mysql_server_version for vtorc Signed-off-by: Andrew Mason <andrew@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: CLI
Component: General
Changes throughout the code base
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Type: Internal Cleanup
Part of #10697.
Current flags:
The text was updated successfully, but these errors were encountered: