-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Report: Parsing OK response from MariaDB can fail during import #11795
Comments
dbussink
added
Type: Bug
Needs Triage
This issue needs to be correctly labelled and triaged
Component: Query Serving
and removed
Needs Triage
This issue needs to be correctly labelled and triaged
labels
Nov 23, 2022
dbussink
added a commit
to planetscale/vitess
that referenced
this issue
Nov 23, 2022
On MariaDB, it's possible that an OK packet has `SERVER_SESSION_STATE_CHANGED` set to true, but it has no additional state change information as the end of the packet is reached. We should not treat this as an error condition and treat this as a proper OK packet. Fixes vitessio#11795 Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
3 tasks
systay
pushed a commit
that referenced
this issue
Nov 23, 2022
On MariaDB, it's possible that an OK packet has `SERVER_SESSION_STATE_CHANGED` set to true, but it has no additional state change information as the end of the packet is reached. We should not treat this as an error condition and treat this as a proper OK packet. Fixes #11795 Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
vitess-bot bot
pushed a commit
that referenced
this issue
Nov 23, 2022
On MariaDB, it's possible that an OK packet has `SERVER_SESSION_STATE_CHANGED` set to true, but it has no additional state change information as the end of the packet is reached. We should not treat this as an error condition and treat this as a proper OK packet. Fixes #11795 Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
frouioui
pushed a commit
that referenced
this issue
Nov 28, 2022
On MariaDB, it's possible that an OK packet has `SERVER_SESSION_STATE_CHANGED` set to true, but it has no additional state change information as the end of the packet is reached. We should not treat this as an error condition and treat this as a proper OK packet. Fixes #11795 Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview of the Issue
While MariaDB support is deprecated (see #9518), we still support importing data from MariaDB through an unmanaged tablet.
Since #10871 we always enable session state tracking as a client capability, but it turns out that MariaDB can return a packet where the
SERVER_SESSION_STATE_CHANGED
bit is set, but subsequently no additional information is available in the packet.This then errors with the following error:
Reproduction Steps
Import data from a recent MariaDB instance
Binary Version
Operating System and Environment details
Log Fragments
The text was updated successfully, but these errors were encountered: