Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the query_analyzer binary #14054

Closed
frouioui opened this issue Sep 20, 2023 · 0 comments · Fixed by #14055
Closed

Remove the query_analyzer binary #14054

frouioui opened this issue Sep 20, 2023 · 0 comments · Fixed by #14055
Labels
Component: Query Serving Type: Internal Cleanup

Comments

@frouioui
Copy link
Member

Feature Description

I have found that the query_analyzer is not used throughout the codebase and the only commits made to it in the recent years were maintenance commits. I think it is fine to remove this binary.

Use Case(s)

Removing it will give us lighter release packages and less code to maintain.
@frouioui frouioui added Type: Feature Request Needs Triage This issue needs to be correctly labelled and triaged Type: Internal Cleanup Component: Query Serving and removed Type: Feature Request Needs Triage This issue needs to be correctly labelled and triaged labels Sep 20, 2023
@frouioui frouioui mentioned this issue Sep 20, 2023
Closed
4 tasks
ajm188 pushed a commit to planetscale/vitess that referenced this issue Sep 20, 2023
remove query_analyzer binary and release
24e2627 
closes vitessio#14054

Signed-off-by: Andrew Mason <andrew@planetscale.com>
@ajm188 ajm188 mentioned this issue Sep 20, 2023
Merged
4 tasks
@BrewTestBot BrewTestBot mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Query Serving Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove query_analyzer binary and release planetscale/vitess
1 participant
@frouioui