Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable maxrows of 10k #3224

Closed
tirsen opened this issue Sep 21, 2017 · 3 comments
Closed

Configurable maxrows of 10k #3224

tirsen opened this issue Sep 21, 2017 · 3 comments

Comments

@tirsen
Copy link
Collaborator

tirsen commented Sep 21, 2017 •
edited
Loading

We need to temporarily increase the 10k limit on rows in result sets for some queries.

AFAICT this seems to be hardcoded currently.

It would be good to be able to:

  • override this on a query by query basis and,
  • be able to change that limit globally using a flag.
@tirsen tirsen changed the title Flag for changing the maxrows of 10k Configurable maxrows of 10k Sep 21, 2017
@tirsen
Copy link
Collaborator Author

tirsen commented Sep 21, 2017

Actually. It looks like globally there is already a flag?

--queryserver-config-max-result-size ?

@bbeaudreault
Copy link
Contributor

That's correct. There's also a warn threshold you can set. At hubspot we set the warm threshold to 10k and limit to 100k so we can fix those queries as we migrate, rather than blow up

@sougou
Copy link
Contributor

sougou commented Sep 21, 2017

I guess I can close this issue :)

@sougou sougou closed this as completed Sep 21, 2017
@snyk-bot snyk-bot mentioned this issue Dec 28, 2021
Open
@ramsemune ramsemune mentioned this issue May 13, 2022
Open
@snyk-bot snyk-bot mentioned this issue May 14, 2022
Open
@ramsemune ramsemune mentioned this issue Sep 8, 2022
Open
@ramsemune ramsemune mentioned this issue Sep 24, 2022
Open
@snyk-bot snyk-bot mentioned this issue Sep 26, 2022
Open
This was referenced Sep 26, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 29, 2022
Open
This was referenced Oct 5, 2022
Open
Open
@ramsemune ramsemune mentioned this issue Jun 26, 2023
Open
@ramsemune ramsemune mentioned this issue Nov 25, 2023
Open
@ramsemune ramsemune mentioned this issue Dec 19, 2023
Open
frouioui pushed a commit to planetscale/vitess that referenced this issue Mar 26, 2024
@planetscale-actions-bot @vmg
CherryPick(vitessio#14076): ci: pool-related test flakyness (vitessio…
7d36df9 
…#3224)

* cherry pick of 14076

* cherry-pick: fix merge conflict

Signed-off-by: Vicent Marti <vmg@strn.cat>

---------

Signed-off-by: Vicent Marti <vmg@strn.cat>
Co-authored-by: Vicent Marti <vmg@strn.cat>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tirsen @bbeaudreault @sougou