Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tablet mysqld port not displayed in vtctld web UI shard display anymore #6597

Closed
aquarapid opened this issue Aug 20, 2020 · 0 comments
Closed

Tablet mysqld port not displayed in vtctld web UI shard display anymore #6597

aquarapid opened this issue Aug 20, 2020 · 0 comments
Milestone
v8.0

Comments

@aquarapid
Copy link
Contributor

This recent change:

4eabc0c#diff-c9b02203aac7ac750300c4cf770645b1L207

removed the long-deprecated mysqld member of the tablet portMap map.

This resulted in the shard display in the vtctld web UI not displaying the mysqld port anymore for each tablet, in addition to the grpc and "vt" (vttablet web UI) ports. This would only of course be an issue if mysqld is listening on a port (instead of just a socket).

We should modify the UI code to pull/display the mysqld port from it's new location in the tablet proto.
@aquarapid aquarapid changed the title https://github.com/vitessio/vitess/commit/4eabc0cfbe6e35d5e0a87ac56e7bf5d99a725f61#diff-c9b02203aac7ac750300c4cf770645b1L207 Tablet mysqld port not displayed in vtctld web UI shard display anymore Aug 20, 2020
aquarapid added a commit to planetscale/vitess that referenced this issue Aug 20, 2020
@aquarapid
Regenerate vtctld2 for vitessio#6597 fix.
713507f 
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
@sougou sougou closed this as completed in 4709403 Aug 20, 2020
sougou added a commit that referenced this issue Aug 20, 2020
@sougou
Merge pull request #6598 from planetscale/jacques_issue6597
3d90385 
Fix #6597 by adding mysqld port display back to vtctld web UI
aquarapid added a commit to planetscale/vitess that referenced this issue Aug 20, 2020
@aquarapid
Fix vitessio#6597 by adding mysqld port display back to vtctld web UI.
c9266d8 
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid added a commit to planetscale/vitess that referenced this issue Aug 20, 2020
@aquarapid
Regenerate vtctld2 for vitessio#6597 fix.
c3c1dde 
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
deepthi added a commit that referenced this issue Aug 20, 2020
@deepthi
Merge pull request #6600 from planetscale/backport_6597
886104d 
Backport of PR #6598 to fix issue #6597 for 7.0 branch
@askdba askdba added this to the v8.0 milestone Oct 6, 2020
@setassociative setassociative mentioned this issue Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.0
Development

No branches or pull requests
2 participants
@aquarapid @askdba