-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile warnings with new go-sqlite3 dep #6631
Labels
Comments
aquarapid
added a commit
to planetscale/vitess
that referenced
this issue
Aug 26, 2020
for CGO code. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
sougou
added a commit
that referenced
this issue
Sep 3, 2020
Address #6631 by reducing optimization level
If this issue is resolved, can we close this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We recently integrated some orchestrator code that depends on sqlite, and uses the go-sqlite3 module.
On newer gcc versions this will throw a warning during a (clean build):
Upstream issue is mattn/go-sqlite3#803 , but it does not seem like it will be addressed soon, and even if it does, the upstream dependencies might take a while to filter down to typical user installs. We should work around it in the Vitess build, even if just in the interest of cleanliness.
The text was updated successfully, but these errors were encountered: