Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile warnings with new go-sqlite3 dep #6631

Closed
aquarapid opened this issue Aug 26, 2020 · 1 comment
Closed

Compile warnings with new go-sqlite3 dep #6631

aquarapid opened this issue Aug 26, 2020 · 1 comment

Comments

@aquarapid
Copy link
Contributor

We recently integrated some orchestrator code that depends on sqlite, and uses the go-sqlite3 module.

On newer gcc versions this will throw a warning during a (clean build):

$ make clean ; make
Wed Aug 26 09:24:23 PDT 2020: Building source tree
# github.com/mattn/go-sqlite3
sqlite3-binding.c: In function ‘sqlite3SelectNew’:
sqlite3-binding.c:129019:10: warning: function may return address of local variable [-Wreturn-local-addr]
129019 |   return pNew;
       |          ^~~~
sqlite3-binding.c:128979:10: note: declared here
128979 |   Select standin;
       |          ^~~~~~~

Upstream issue is mattn/go-sqlite3#803 , but it does not seem like it will be addressed soon, and even if it does, the upstream dependencies might take a while to filter down to typical user installs. We should work around it in the Vitess build, even if just in the interest of cleanliness.

aquarapid added a commit to planetscale/vitess that referenced this issue Aug 26, 2020
for CGO code.

Signed-off-by: Jacques Grove <aquarapid@gmail.com>
sougou added a commit that referenced this issue Sep 3, 2020
Address #6631 by reducing optimization level
@GuptaManan100
Copy link
Member

If this issue is resolved, can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants