Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: statsTabletType not initialized in 7.0.3 #6988

Closed
dweitzman opened this issue Nov 2, 2020 · 1 comment · Fixed by #6989
Closed

Regression: statsTabletType not initialized in 7.0.3 #6988

dweitzman opened this issue Nov 2, 2020 · 1 comment · Fixed by #6989

Comments

@dweitzman
Copy link
Member

Looks like probably something in the refactoring in #6461 may have changed things so that "TabletType" on a tablet's /debug/vars starts out empty instead of the correct initial value

7-beta doesn't have the issues, which contributes to my guess that it's the PR that refactored the relevant code and got included in 7.0.3
@dweitzman
Copy link
Member Author

Adding statsTabletType.Set(topoproto.TabletTypeLString(tablet.Type)) as the first line of TabletManager.Start seems to fix it

@dweitzman dweitzman mentioned this issue Nov 3, 2020
Merged
dweitzman added a commit to dweitzman/vitess that referenced this issue Nov 5, 2020
@dweitzman
Correctly initialize the TabletType stats
060bc8e 
Fixes vitessio#6988

Signed-off-by: David Weitzman <dweitzman@pinterest.com>
@deepthi deepthi mentioned this issue Jan 27, 2021
Merged
8 tasks
deepthi pushed a commit to planetscale/vitess that referenced this issue Jan 27, 2021
@dweitzman @deepthi
Correctly initialize the TabletType stats
0533e30 
Fixes vitessio#6988

Signed-off-by: David Weitzman <dweitzman@pinterest.com>
@deepthi deepthi mentioned this issue Jan 27, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly initialize the TabletType stats dweitzman/vitess
1 participant
@dweitzman