Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate VDiff rpc to VtctldServer #7931

Closed
ajm188 opened this issue Apr 22, 2021 · 1 comment
Closed

Migrate VDiff rpc to VtctldServer #7931

ajm188 opened this issue Apr 22, 2021 · 1 comment

Comments

@ajm188
Copy link
Contributor

ajm188 commented Apr 22, 2021

Feature Description

We should have a gRPC endpoint to call VDiff on the new VtctldServer, similar to the vtctlclient VDiff vtctl command.

Use Case(s)

Programmatically calling Vdiff from the new clients.

Notes

This is going to involve a series of preperatory refactors to enable us to call TrafficSwitcher/VDiff code (vdiffer relies on traffic switcher) from outside of package wrangler and then it should be a simple final change to add the RPC endpoint.

@ajm188 ajm188 self-assigned this Apr 22, 2021
@ajm188 ajm188 removed their assignment Mar 14, 2022
@frouioui frouioui added this to v16.0.0 Nov 23, 2022
@frouioui frouioui moved this to Backlog in v16.0.0 Nov 23, 2022
@frouioui frouioui removed this from v16.0.0 Feb 8, 2023
@frouioui frouioui added this to v17.0.0 Feb 8, 2023
@frouioui frouioui moved this to Backlog in v17.0.0 Feb 8, 2023
@ajm188 ajm188 removed P2 labels Mar 9, 2023
@ajm188
Copy link
Contributor Author

ajm188 commented Mar 14, 2023

closing as dupe of #12155

@ajm188 ajm188 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in v17.0.0 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants