Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] Cleanup wrangler wrappers, migrate checkIfJournalExistsOnTablet to package workflow #8193

Merged
merged 2 commits into from
May 27, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented May 26, 2021

Description

What it says in the title. I think long-term that the (newly-named) CheckReshardingJournalExistsOnTablet should stop being exported, but we need to access it from package wrangler for now, so I left a TODO comment.

Also, the previous implementation had an unnecessary check on if !exists which would always be true, so I removed the check.

[Edit] Oh, also, this is almost certainly going to run into merge conflicts with #8190 so 🤷 I'll just rebase whichever one loses

Related Issue(s)

#7931

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Andrew Mason <amason@slack-corp.com>
…ge workflow

I also removed the unnecessary `if !exists` check, since not taking that
path was impossible.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Copy link
Member

@rafael rafael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajm188 ajm188 merged commit 4b7f847 into vitessio:master May 27, 2021
@ajm188 ajm188 deleted the am_cleanup_wrangler_wrappers branch May 27, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants