Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online DDL: allow users to see migration log (in case of migration failure) #8178

Closed
shlomi-noach opened this issue May 25, 2021 · 3 comments · Fixed by #8493
Closed

Online DDL: allow users to see migration log (in case of migration failure) #8178

shlomi-noach opened this issue May 25, 2021 · 3 comments · Fixed by #8493
Assignees
@shlomi-noach
Labels
Component: Query Serving Type: Feature Request

Comments

@shlomi-noach
Copy link
Contributor

Feature Description

When an online DDL migration fails, specifically gh-ost or pt-online-schema-change, there's a migration.log file. Its location is indicated in log_path column in show vitess_migrations.

However, there is no mechanism to view the contents of that log; if the user doesn't have ssh/exec access, then they're unable to view the log.

Suggestion: support a query like SHOW VITESS_MIGRATION_LOG FOR '<uuid>' or similar, that will print out the contents of the migration log, if exists, or error, if not exists.

Note that the migration log is implicitly removed if the migration is successful. This feature is only of interest for failed migrations.
@shlomi-noach shlomi-noach self-assigned this May 25, 2021
@shlomi-noach
Copy link
Contributor Author

General tracking issue: #6926

@shlomi-noach shlomi-noach mentioned this issue May 26, 2021
Merged
2 tasks
@shlomi-noach
Copy link
Contributor Author

#8192 copies gh-ost's FATAL message, if any, into the message column in schema_migrations. It a good step towards better visibility.

@shlomi-noach shlomi-noach mentioned this issue Jul 19, 2021
Merged
2 tasks
@shlomi-noach
Copy link
Contributor Author

Addressed by #8493

@shlomi-noach shlomi-noach mentioned this issue Jul 26, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlomi-noach shlomi-noach

Labels
Component: Query Serving Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SHOW VITESS_MIGRATION '...' LOGS, retain logs for 24 hours planetscale/vitess
1 participant
@shlomi-noach