Online DDL: read and publish gh-ost FATAL message where possible #8192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
gh-ost
migrations, andgh-ost
fails,gh-ost
produces a detailed error log. But thevttablet
that executesgh-ost
only tells something likefailed running command: ... ... error=exit status 1
.When the user consequently runs
SHOW VITESS_MIGRATIONS LIKE '...'
they see aforementioned generic error in themessage
column:This PR provides more useful information in in
message
column.When
gh-ost
fails, it typically fails with aFATAL
log message. This PR extract thatFATAL
log message, if possible. If successful, it replaces the generic error with the more informative message from the log. Examples:Related Issue(s)
Checklist
Deployment Notes