Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data races in grpcvtctldserver tests #8299

Closed
ajm188 opened this issue Jun 9, 2021 · 0 comments · Fixed by #8300
Closed

Fix data races in grpcvtctldserver tests #8299

ajm188 opened this issue Jun 9, 2021 · 0 comments · Fixed by #8300
Assignees
@ajm188
Labels
Component: Build/CI Type: Bug

Comments

@ajm188
Copy link
Contributor

ajm188 commented Jun 9, 2021

Overview of the Issue

These were introduced in #8113, which is using t.Parallel() without using the testutil constructor, which is designed to guard against this exact datarace.

Example failure: https://github.com/vitessio/vitess/pull/8284/checks?check_run_id=2787001167
@ajm188 ajm188 self-assigned this Jun 9, 2021
ajm188 added a commit to tinyspeck/vitess that referenced this issue Jun 9, 2021
@ajm188
Use shared testing helper which guards against races in tmclient cons…
f964e01 
…truction

Fixes vitessio#8299

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 mentioned this issue Jun 9, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajm188 ajm188

Labels
Component: Build/CI Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use shared testing helper which guards against races in tmclient construction tinyspeck/vitess
1 participant
@ajm188