Fix the race between PromoteReplica and replication manager tick (#9859) - release 12 #10076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essio#9859) * test: improve test to check that replication manager is stopped before we make any changes in MySQL Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: stop the replication manager first in PromoteReplica call Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: add comments to replication manager setTabletType Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: add comment for SetReplicationSource in wrangler Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: add comments to SetReplicationSource in reparentutil Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added
Type: Bug
Component: Cluster management
Backport
GuptaManan100
changed the title
systay
approved these changes
Apr 12, 2022
…r-race-12 Signed-off-by: Manan Gupta <manan@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #9859
Related Issue(s)
Checklist
Deployment Notes