-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backwards compatible replication status to state transition #10167
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2721fdb
This effectively reverts 65226ad1d77629fe29e852393a19250a9a910024
mattlord fd66496
This adds the new state fields back so that we can switch to them in v15
mattlord 0d18e9d
Allow for safe/smooth upgrades within 14.0-SNAPSHOT
mattlord 3dd7895
Avoid intermediate io_thread_connecting protobuf field
mattlord 841f1cc
Continue using replication states in v14 tests
mattlord dd34bdc
Translate SQL running status to state as well
mattlord 06fcc84
Use backward compat ReplicaWasRunning check
mattlord 613da12
Add backward compat SQLThreadWasRunning function
mattlord e340dfc
Add comment about when backward compat can be removed
mattlord c300f63
Support older clients with new tablets
mattlord c76f6e9
feat: remove SQLThreadWasRunning unused function
GuptaManan100 1717e38
test: add an upgrade test to verify the replicationstatus is backward…
GuptaManan100 65369fe
feat: fix ReplicaWasRunning so that it doesn't have code dependent on…
GuptaManan100 2a3af24
refactor: rename function to reflect the output type
GuptaManan100 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍