Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement VDiff2 Delete Action #10608

Merged
merged 9 commits into from
Jul 2, 2022
Merged

Implement VDiff2 Delete Action #10608

merged 9 commits into from
Jul 2, 2022

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Jun 28, 2022 •
edited
Loading

Description

The primary thing that this PR does is add the VDiff -- --v2 <keyspace>.<workflow> delete {all,<UUID>} VDiff command action.

Secondly, it purges any VDiff records for a workflow when that workflow is deleted via:

  • <workflow> complete
  • <workflow> cancel
  • <workflow> delete

Lastly, it also adds a --verbose flag for VDiff show output.

Related Issue(s)

Checklist

@mattlord mattlord force-pushed the vdiff2_delete branch 2 times, most recently from 566848e to 7a1ba5c Compare June 28, 2022 18:15
@mattlord mattlord added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication release notes labels Jun 28, 2022
@mattlord
Implement VDiff2 delete command
4a25442 
Also add --verbose flag for VDiff output

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord changed the title Implement VDiff2 delete command Implement VDiff2 delete Action Jun 28, 2022
@mattlord
Delete vdiff metadata associated with a deleted workflow
febbc8e 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Tweaks after self review
92af871 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord changed the title Implement VDiff2 delete Action Implement VDiff2 Delete Action Jun 29, 2022
@mattlord mattlord marked this pull request as ready for review June 29, 2022 06:52
@mattlord
Self review #2
baea4ef 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022 •
edited by rohit-nayak-ps
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@mattlord
Spelling is herd
7024e23 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord removed the request for review from deepthi June 29, 2022 07:18
@mattlord
Add test for vdiff data cleanup on workflow deletion
5f9f154 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Caught mistake on self-review #3
0f4b832 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Add a couple more delete tests
8f87fed 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Clear out vdiff_log table as well on workflow deletion
516a12c 
Signed-off-by: Matt Lord <mattalord@gmail.com>
rohit-nayak-ps
rohit-nayak-ps approved these changes Jul 2, 2022
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattlord mattlord merged commit 0d1d001 into vitessio:main Jul 2, 2022
@mattlord mattlord deleted the vdiff2_delete branch July 2, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

Assignees
No one assigned
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VDiff2: add Delete {all,<UUID>} Action
2 participants
@mattlord @rohit-nayak-ps