Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decouple olap tx timeout from oltp tx timeout #10946

Merged
merged 15 commits into from
Sep 7, 2022
Merged

decouple olap tx timeout from oltp tx timeout #10946

merged 15 commits into from
Sep 7, 2022

Commits on Aug 23, 2022

  1. decouple olap tx timeout from oltp tx timeout 

    Since workload=olap bypasses the query timeouts
(--queryserver-config-query-timeout) and also row limits, the natural
assumption is that it also bypasses the transaction timeout.

This is not the case, e.g. for a tablet where the
--queryserver-config-transaction-timeout is 10.

This commit:

 * Adds new CLI flag and YAML field to independently configure TX
   timeouts for OLAP workloads (--queryserver-config-olap-transaction-timeout).
 * Decouples TX kill interval from OLTP TX timeout via new CLI flag and
   YAML field (--queryserver-config-transaction-killer-interval).

Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    9a03214 View commit details
    Browse the repository at this point in the history

  2. decouple ol{a,t}p tx timeouts: pr comments vitessio#1 

    Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    035f971 View commit details
    Browse the repository at this point in the history

  3. decouple ol{a,t}p tx timeouts: pr comments vitessio#2 consolidate tim… 

    …eout logic in sc

Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    e4e0ac6 View commit details
    Browse the repository at this point in the history

  4. decouple ol{a,t}p tx timeouts: remove unused tx killer flag 

    Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    160edbf View commit details
    Browse the repository at this point in the history

  5. decouple ol{a,t}p tx timeouts: update 15_0_0_summary.md 

    Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    e589d31 View commit details
    Browse the repository at this point in the history

  6. decouple ol{a,t}p tx timeouts: fix race cond 

    Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    98b3941 View commit details
    Browse the repository at this point in the history

  7. decouple ol{a,t}p tx timeouts: pr comments vitessio#3 -txProps.timeou… 

    …t, +sc.expiryTime

Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    6aba785 View commit details
    Browse the repository at this point in the history

  8. decouple ol{a,t}p tx timeouts: pr comments vitessio#4 -atomic.Value f… 

    …or expiryTime

Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    24e4952 View commit details
    Browse the repository at this point in the history

  9. decouple ol{a,t}p tx timeouts: fix race cond (without atomic.Value) 

    Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    870338f View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. decouple ol{a,t}p tx timeouts: pr comments vitessio#5 -unused funcs, … 

    …fix comments, set ticks interval once

Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    7f0c88d View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2022

  1. decouple ol{a,t}p tx timeouts: pr comments vitessio#5 +txkill tests 

    Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    17e7b7f View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. merge <- master 

    Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e98cef8 View commit details
    Browse the repository at this point in the history

  2. revert fmt changes 

    Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a909c32 View commit details
    Browse the repository at this point in the history

  3. implement pr review suggestion 

    Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    49db347 View commit details
    Browse the repository at this point in the history

  4. merge <- main 

    Signed-off-by: Max Englander <max@planetscale.com>
    @maxenglander
    maxenglander committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    64002dc View commit details
    Browse the repository at this point in the history