Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Stream queries that query by schema_name #11090

Merged

Conversation

maxenglander
Copy link
Collaborator

@maxenglander maxenglander commented Aug 25, 2022

Description

Tabletserver Execute() replaces bindVars[BvSchemaName] with the tablet
database name. In practice this means that queries like:

SELECT * FROM INFORMATION_SCHEMA.SCHEMATA WHERE SCHEMA_NAME = 'data';

are rewritten to queries like:

SELECT * FROM INFORMATION_SCHEMA.SCHEMATA WHERE SCHEMA_NAME = 'vt_data';

Tabletserver Stream() does not replicate this
behavior, breaking queries like the one above when workload is OLAP.

This PR applies the schema-name-replace logic to Stream() calls.

Related Issue(s)

Fixes #11081.

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 25, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me. I'll let someone else with more knowledge about the query engine (cc @harshit-gangal) review and merge this though.

@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Aug 30, 2022
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good.
Lets add and e2e test here go/test/endtoend/vtgate/gen4/system_schema_test.go
in TestDbNameOverride

you can set the workload first using the set command and then call the same information_query again.
use the helper method utils.Exec

Tabletserver Execute() replaces bindVars[BvSchemaName] with the tablet
database name. In practice this means that queries like:

  SELECT * FROM INFORMATION_SCHEMA.SCHEMATA WHERE SCHEMA_NAME = 'data';

are rewritten to queries like:

  SELECT * FROM INFORMATION_SCHEMA.SCHEMATA WHERE SCHEMA_NAME = 'vt_data';

Tabletserver Stream() and StreamExecute() do not replicate this
behavior, breaking queries like the one above when workload is OLAP.

This PR applies the schema-name-replace logic to Stream() and
StreamExecute().

Signed-off-by: Max Englander <max@planetscale.com>
Signed-off-by: Max Englander <max@planetscale.com>
@maxenglander
Copy link
Collaborator Author

Thanks @harshit-gangal I've added that test

@harshit-gangal harshit-gangal merged commit ac89c8a into vitessio:main Sep 7, 2022
@maxenglander maxenglander deleted the maxeng-gh-11081-olap-infsch branch September 20, 2022 16:47
@deepthi deepthi changed the title tabletserver stream replace schema name bindvar Rewrite Stream queries that query by schema_name Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Flyway query on information schema not working in OLAP mode
3 participants