-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip TestComparisonSemantics
test
#11474
Merged
frouioui
merged 1 commit into
vitessio:main
from
planetscale:skip-TestComparisonSemantics
Oct 12, 2022
Merged
Skip TestComparisonSemantics
test
#11474
frouioui
merged 1 commit into
vitessio:main
from
planetscale:skip-TestComparisonSemantics
Oct 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
requested review from
harshit-gangal,
systay and
mattlord
as code owners
October 12, 2022 13:27
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
dbussink
approved these changes
Oct 12, 2022
systay
approved these changes
Oct 12, 2022
frouioui
added a commit
to planetscale/vitess
that referenced
this pull request
Oct 12, 2022
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
added a commit
to planetscale/vitess
that referenced
this pull request
Oct 12, 2022
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
added a commit
to planetscale/vitess
that referenced
this pull request
Oct 12, 2022
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
This was referenced Oct 12, 2022
frouioui
added a commit
that referenced
this pull request
Oct 13, 2022
frouioui
added a commit
that referenced
this pull request
Oct 13, 2022
frouioui
added a commit
that referenced
this pull request
Oct 13, 2022
This was referenced Oct 25, 2022
3 tasks
This was referenced May 22, 2023
This was referenced Jun 20, 2023
This was referenced Feb 2, 2024
This was referenced Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
TestComparisonSemantics
test started failing after a recent release of MySQL. This will unblock the failure on theUnit Test (mysql80)
workflow.Checklist