-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codeql
workflow timeout issue
#11760
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
In commit 6aba78c you can see the workflow fail (https://github.com/vitessio/vitess/actions/runs/3484154076/jobs/5828414742) and send a slack notification: https://vitess.slack.com/archives/C04BMRXQUL9/p1668644474844189 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
* increase the timeout to build binaries in codeql workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test codeql workflow on pr Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of Slack Workflow Notification Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of if condition to send slack message Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fail if needed Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * clean up codeql workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
* increase the timeout to build binaries in codeql workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test codeql workflow on pr Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of Slack Workflow Notification Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of if condition to send slack message Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fail if needed Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * clean up codeql workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Description
The CodeQL workflow has been failing due to timeouts. This Pull Request increases the timeout for the
make build
.There is also a new integration that sends a slack message whenever the workflow fails so we can easily know if the build starts failing. It is usually tough the know if the build fails, we have to manually look at it since the PR is executed in a CRON. The message goes to the
#codeql
channel of our OSS Slack workplace.Related Issue(s)
Fixes #11761
Checklist
Deployment Notes