Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codeql workflow timeout issue #11760

Merged
merged 6 commits into from
Nov 22, 2022
Merged

Fix codeql workflow timeout issue #11760

merged 6 commits into from
Nov 22, 2022

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Nov 16, 2022

Description

The CodeQL workflow has been failing due to timeouts. This Pull Request increases the timeout for the make build.

There is also a new integration that sends a slack message whenever the workflow fails so we can easily know if the build starts failing. It is usually tough the know if the build fails, we have to manually look at it since the PR is executed in a CRON. The message goes to the #codeql channel of our OSS Slack workplace.

Related Issue(s)

Fixes #11761

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 16, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Copy link
Member Author

@frouioui frouioui marked this pull request as ready for review November 17, 2022 00:23
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@frouioui frouioui merged commit 2b1f483 into main Nov 22, 2022
@frouioui frouioui deleted the fix-codeql-workflow branch November 22, 2022 06:16
frouioui added a commit to planetscale/vitess that referenced this pull request Dec 14, 2022
* increase the timeout to build binaries in codeql workflow

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test codeql workflow on pr

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* addition of Slack Workflow Notification

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* addition of if condition to send slack message

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fail if needed

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* clean up codeql workflow

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
deepthi pushed a commit that referenced this pull request Jan 4, 2023
* increase the timeout to build binaries in codeql workflow

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test codeql workflow on pr

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* addition of Slack Workflow Notification

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* addition of if condition to send slack message

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fail if needed

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* clean up codeql workflow

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CodeQL workflow timeouts
4 participants