Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[planner] Better AST equality #11867

Merged
merged 11 commits into from
Dec 5, 2022
Merged

[planner] Better AST equality #11867

merged 11 commits into from
Dec 5, 2022

Commits on Dec 1, 2022

  1. make it possible to do deep comparisons with custom logic 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    35faa86 View commit details
    Browse the repository at this point in the history

  2. use the new EqualS function to do deep semantic equality 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    d5cc9f9 View commit details
    Browse the repository at this point in the history

  3. re gen the asthelpergen integration test data 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    a4cde5c View commit details
    Browse the repository at this point in the history

  4. update equal gen comment 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    9aac5cf View commit details
    Browse the repository at this point in the history

  5. test: add unit tests showing the new EqualsExpr functionality 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    2736e74 View commit details
    Browse the repository at this point in the history

  6. [planner] use the semantic equality in more places 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    b22efb4 View commit details
    Browse the repository at this point in the history

  7. comments - update to reflect new code 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    071b7f4 View commit details
    Browse the repository at this point in the history

  8. small fixes around tests 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    dc0f37c View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. update integration test build 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    7ef0345 View commit details
    Browse the repository at this point in the history

  2. use semantic equality for Anding together expressions 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    432b284 View commit details
    Browse the repository at this point in the history

  3. test: simplify test 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    c4499f4 View commit details
    Browse the repository at this point in the history