v15 backport: Online DDL: fix 'vtctlclient OnlineDDL' template queries (#11889) #11951
+24
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #11889
Description
At some point the behavior of
sqlparser.QueryMatchesTemplates(...)
changed such that if the template has multiple recurring'val'
values, the new behavior expects them to be equal.This breaks the
vtctlclient OnlineDDL
behavior, because OnlineDDL's query templates used recurring'val'
. The templates are now updated, and a new unit test validates their behavior.Related Issue(s)
#11893
#6926
Checklist
Deployment Notes