Remove removed flags from being used for v16+ binaries #12128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the flags removed from v16 to be set on binaries from that and later releases. This change is required because we run upgrade-downgrade tests which spawn binaries from the next release too. So the flags removed in #12083 and #12085 have to be put behind a condition check to see if the spawned binary is from a version higher than 15 or not.
This PR makes these changes to fix the upgrade-downgrade tests which are currently broken as seen in https://github.com/vitessio/vitess/actions/runs/3949422838/jobs/6763433594
Related Issue(s)
Checklist
Deployment Notes