Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mysqld.GetSchema: tolerate tables being dropped while inspecting schema #12641

Merged
merged 7 commits into from
Mar 20, 2023
Merged

Mysqld.GetSchema: tolerate tables being dropped while inspecting schema #12641

merged 7 commits into from
Mar 20, 2023

Commits on Mar 16, 2023

  1. Mysqld.GetSchema: tolerate tables being dropped while inspecting schema 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    be883bc View commit details
    Browse the repository at this point in the history

  2. lack of primary key columns in STATISTICS does not mean table is drop… 

    …ped. It can also mean the table does not have PRIMARY KEY

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    eed2706 View commit details
    Browse the repository at this point in the history

  3. populate validTds rather than rely on nil hints 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    85f0273 View commit details
    Browse the repository at this point in the history

  4. re-introdce earlier check 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    79cfdc2 View commit details
    Browse the repository at this point in the history

  5. use validTds, sync 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    6ebebd8 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2023

  1. due to many tests consistently failing, trying a different approach: … 

    …we keep the table, but with empty column/key/fields info

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    39cdc58 View commit details
    Browse the repository at this point in the history

  2. grammar 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    6d866c8 View commit details
    Browse the repository at this point in the history