Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlparser: Add parsing support for wkt funcs #12651

Merged
merged 3 commits into from
Mar 27, 2023
Merged

sqlparser: Add parsing support for wkt funcs #12651

merged 3 commits into from
Mar 27, 2023

Conversation

Ayman161803
Copy link
Contributor

@Ayman161803 Ayman161803 commented Mar 17, 2023 •
edited
Loading

Description

This PR adds parsing support to functions that create geometries from Well Known Text. Mysql reference for the same can be found here

Related Issue(s)

#8604

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
Copy link
Member

This is the correct link for the doc - https://dev.mysql.com/doc/refman/8.0/en/gis-wkt-functions.html#function_st-geomfromtext

GuptaManan100
GuptaManan100 requested changes Mar 22, 2023
View reviewed changes
go/vt/sqlparser/keywords.go Outdated Show resolved Hide resolved
@Ayman161803
feat: add parsing support for wkt funcs
8cb62ce 
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
@Ayman161803
replace string to enum in GeomFromWkt
237b7ba 
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
@Ayman161803
reduce number of tokens
b5076c7 
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Mar 24, 2023
@GuptaManan100 GuptaManan100 merged commit 5a3ad0d into vitessio:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ayman161803 @GuptaManan100 @systay