Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing support to wkb spatial funcs #12739

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Conversation

Ayman161803
Copy link
Contributor

@Ayman161803 Ayman161803 commented Mar 28, 2023

Description

This PR adds parsing support to functions that create geometries from Well Known Blob. Mysql reference for the same can be found here

Related Issue(s)

#8604

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 28, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 28, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@Ayman161803 Ayman161803 force-pushed the wkb-funcs branch 2 times, most recently from d1303c0 to 7d439fe Compare March 28, 2023 07:30
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 28, 2023
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GuptaManan100
Copy link
Member

You'll need to update you branch by merging main

Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
@GuptaManan100 GuptaManan100 changed the title feat: add parsing support to wkb spatial funcs Add parsing support to wkb spatial funcs Mar 31, 2023
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
@frouioui frouioui merged commit 1fce6ab into vitessio:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants