Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parsing support to point property functions #12904

Merged
merged 3 commits into from
Apr 23, 2023
Merged

Add parsing support to point property functions #12904

merged 3 commits into from
Apr 23, 2023

Conversation

Ayman161803
Copy link
Contributor

@Ayman161803 Ayman161803 commented Apr 16, 2023 •
edited
Loading

Description

This PR adds parsing support to geomtry property functions. Mysql reference for the same can be found here

Related Issue(s)

#8604

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@Ayman161803
feat: add parsing support to point property functions
873ad85 
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
@github-actions github-actions bot added this to the v17.0.0 milestone Apr 16, 2023
GuptaManan100
GuptaManan100 requested changes Apr 17, 2023
View reviewed changes
go/vt/sqlparser/keywords.go Outdated Show resolved Hide resolved
go/vt/sqlparser/sql.y Outdated Show resolved Hide resolved
@Ayman161803
fix indent errors and maintain alphabetical order in sqlparser/keywords
16c56e6 
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Apr 20, 2023
frouioui
frouioui reviewed Apr 20, 2023
View reviewed changes
go/vt/sqlparser/ast.go Outdated Show resolved Hide resolved
@Ayman161803
maintain alphabetical order in sqlparser/constants.go and format comm…
d0f7db1 
…ent appropriately

Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
@GuptaManan100 GuptaManan100 merged commit d59ac4c into vitessio:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v17.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Ayman161803 @frouioui @GuptaManan100