-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flags] extract tabletenv seconds type #12920
Merged
ajm188
merged 17 commits into
vitessio:main
from
planetscale:andrew/extract-tabletenv-seconds-type
Apr 21, 2023
Merged
[flags] extract tabletenv seconds type #12920
ajm188
merged 17 commits into
vitessio:main
from
planetscale:andrew/extract-tabletenv-seconds-type
Apr 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajm188
force-pushed
the
andrew/extract-tabletenv-seconds-type
branch
from
April 18, 2023 10:30
ce934bd
to
e709888
Compare
ajm188
force-pushed
the
andrew/extract-tabletenv-seconds-type
branch
2 times, most recently
from
April 18, 2023 22:25
e45a077
to
259ec2d
Compare
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
this one is a bit annoying because while the _flags_ are themselves already `time.Duration` (where we want to end up), the config also can be marshalled from yaml, so we need to shim in a potentially breaking change (hence the deprecation phase) to read pure durations there Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
force-pushed
the
andrew/extract-tabletenv-seconds-type
branch
from
April 20, 2023 17:50
1a94279
to
df6e976
Compare
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
requested review from
harshit-gangal,
systay,
shlomi-noach,
rohit-nayak-ps,
mattlord and
deepthi
as code owners
April 21, 2023 13:45
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
ajm188
changed the title
Andrew/extract tabletenv seconds type
[flags] extract tabletenv seconds type
Apr 21, 2023
ajm188
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
Component: CLI
labels
Apr 21, 2023
rohit-nayak-ps
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
❤️ the DeprecatedFloat64Seconds pattern
deepthi
approved these changes
Apr 21, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: CLI
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two main goals:
Seconds
type out ofpackage tabletenv
, so that in a separate PR I have in progress, another package (whichtabletenv
will need to import) can import or otherwise reference the type without creating an import cycle.time.Duration
types. One release after this ships, we would then be able to turn these types from our custom type into Durations and delete the custom type from the codebase.For my purposes, in full transparency, I need (1), and only want (2) if it's not too 🌶️ of a move.
Some notes
tabletenv.ReplicationTrackerConfig
this one is a bit annoying because while the flags are themselves already
time.Duration
(where we want to end up), the config also can be marshalled from yaml, so we need to shim in a potentially breaking change (hence the deprecation phase) to read pure durations thereRelated Issue(s)
Seconds
type fromtabletenv
toflagutil
(or other appropriate package) #11891Checklist
Deployment Notes