-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parsing support to := operator #13032
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitessio/query-serving This is good from @Ayman161803. The current changes adds the parsing support for the assignment operator, but I tested out our planner, it doesn't handle it well. The planner needs to realize that an assigment operator is basically assigning the user defined variable and then using it, so we need to plan it as a set and then whatever the command is. |
Signed-off-by: Manan Gupta <manan@planetscale.com>
I have explicitly disallowed this expression in the planner for now. |
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
Description
This PR adds support to assignment operator
:=
to parse queries of the type mentioned in #10760.The MySQL docs can be found here - https://dev.mysql.com/doc/refman/8.0/en/assignment-operators.html
Related Issue(s)
#10760
#8604
Checklist
Deployment Notes