-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add parsing support to checksum calcs #13173
Conversation
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Ayman <76606666+Ayman161803@users.noreply.github.com>
Signed-off-by: Ayman <76606666+Ayman161803@users.noreply.github.com>
Signed-off-by: Ayman161803 <mohammedaymannawaz@gmail.com>
{ | ||
$$ = &ChecksumExpr{Tables: $3} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this into its own checksum_statement
expression? It also doesn't seem to support the full syntax, see https://dev.mysql.com/doc/refman/8.0/en/checksum-table.html.
There's the QUICK
or EXTENDED
options at the end that we don't seem to parse here?
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
This PR was closed because it has been stale for 7 days with no activity. |
Description
This PR adds support to statements of type
CHECKSUM TABLE table1name, table2name....
Related Issue(s)
#13090
#8604
Checklist
Deployment Notes